netdev - Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1689af9c618.2807.d241da8dbb85b87157d6a44ac288e71f@tuxdriver.com>
Date:   Tue, 29 Jan 2019 19:58:07 +0100
From:   Tuxdriver <nhorman@...driver.com>
To:     Marcelo Ricardo Leitner <marcelo.leitner@...il.com>,
        Xin Long <lucien.xin@...il.com>
CC:     network dev <netdev@...r.kernel.org>, <linux-sctp@...r.kernel.org>,
        <davem@...emloft.net>
Subject: Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream_out

I was initially under the impression that with Kent's repost, the radixtree 
(which is what I think you meant by rhashtables) updates would be merged 
imminently, but that doesn't seem to be the case.  I'd really like to know 
what the hold up there is, as that patch seems to have been stalled for 
months.  I hate the notion of breaking the radixtree patch, but if it's 
status is indeterminate, then, yes, we probably need to go with xins patch 
for the short term, and let Kent fix it up in due course.

Neil

On January 29, 2019 1:06:33 PM Marcelo Ricardo Leitner 
<marcelo.leitner@...il.com> wrote:

> On Thu, Nov 29, 2018 at 02:42:56PM +0800, Xin Long wrote:
>> Now when using stream reconfig to add out streams, stream->out
>> will get re-allocated, and all old streams' information will
>> be copied to the new ones and the old ones will be freed.
>>
>> So without stream->out_curr updated, next time when trying to
>> send from stream->out_curr stream, a panic would be caused.
>>
>> This patch is to check and update stream->out_curr when
>> allocating stream_out.
>>
>> v1->v2:
>>   - define fa_index() to get elem index from stream->out_curr.
>>
>> Fixes: 5bbbbe32a431 ("sctp: introduce stream scheduler foundations")
>> Reported-by: Ying Xu <yinxu@...hat.com>
>> Reported-by: syzbot+e33a3a138267ca119c7d@...kaller.appspotmail.com
>> Signed-off-by: Xin Long <lucien.xin@...il.com>
>
> We are sort of mixing things up here. We have a bug on SCTP stack that
> triggers panics. As good practices recommends, the code should be as
> generic as possible and the SCTP-only was dropped in favor of a more
> generic one, fixing rhashtables instead. Okay. But then we discovered
> rhashtables are going away and we are now waiting on a restructing
> to fix the panic. That's not good, especially because it cannot and
> should not be backported into -stable trees.
>
> That said, we should not wait for the restructuring to _implicitly_
> fix the bug. We should pursuit both fixes here:
> - Apply this patch, to fix SCTP stack and allow it to be easily
>  backportable.
> - Apply the generic fix, which is the restructuring, whenever it
>  actually lands.
>
> Thoughts?
>
> Thanks,
> Marcelo


Sent with AquaMail for Android
https://www.mobisystems.com/aqua-mail