netdev - Re: [PATCH] ucc_geth: Reset BQL queue when stopping device

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190129.153350.778783567985515916.davem@davemloft.net>
Date:   Tue, 29 Jan 2019 15:33:50 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     Mathias.Thore@...inera.com
Cc:     leoyang.li@....com, christophe.leroy@....fr,
        netdev@...r.kernel.org, linuxppc-dev@...ts.ozlabs.org,
        David.Gounaris@...inera.com, Joakim.Tjernlund@...inera.com
Subject: Re: [PATCH] ucc_geth: Reset BQL queue when stopping device

From: Mathias Thore <Mathias.Thore@...inera.com>
Date: Tue, 29 Jan 2019 08:07:54 +0000

> Is there a scenario where we are clearing the TX ring but don't want to reset the BQL TX queue?
> 
> I think it makes sense to keep it in ucc_geth_free_tx since the
> reason it is needed isn't the timeout per se, but rather the
> clearing of the TX ring. This way, it will be performed no matter
> why the driver ends up calling this function.

I absolutely think the BQL reset should remain in ucc_geth_free_tx().

That way if another callsite for ucc_geth_free_tx() emerges that does
need the BQL queue reset, it won't be "forgotten".