netdev - Re: [PATCH v2 net 7/7] virtio_net: Differentiate sk_buff and xdp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Tue, 29 Jan 2019 10:49:45 +0800
From:   Jason Wang <jasowang@...hat.com>
To:     Toshiaki Makita <makita.toshiaki@....ntt.co.jp>,
        "David S. Miller" <davem@...emloft.net>,
        "Michael S. Tsirkin" <mst@...hat.com>
Cc:     netdev@...r.kernel.org, virtualization@...ts.linux-foundation.org
Subject: Re: [PATCH v2 net 7/7] virtio_net: Differentiate sk_buff and
 xdp_frame on freeing


On 2019/1/29 上午10:35, Toshiaki Makita wrote:
> On 2019/01/29 11:23, Jason Wang wrote:
>> On 2019/1/29 上午8:45, Toshiaki Makita wrote:
> ...
>>> @@ -2666,10 +2696,10 @@ static void free_unused_bufs(struct
>>> virtnet_info *vi)
>>>        for (i = 0; i < vi->max_queue_pairs; i++) {
>>>            struct virtqueue *vq = vi->sq[i].vq;
>>>            while ((buf = virtqueue_detach_unused_buf(vq)) != NULL) {
>>> -            if (!is_xdp_raw_buffer_queue(vi, i))
>>> +            if (!is_xdp_frame(buf))
>>
>> I believe this is the last user of is_xdp_raw_buffer_queue(), maybe you
>> can sent a patch on top to remove it.
> Actually patch2 added new users of it ;)


Right, I missed that.

Thanks


>
>>
>>>                    dev_kfree_skb(buf);
>>>                else
>>> -                xdp_return_frame(buf);
>>> +                xdp_return_frame(ptr_to_xdp(buf));
>>>            }
>>>        }
>>>    
>>
>> Acked-by: Jason Wang <jasowang@...hat.com>
>>
> Thanks!
>