netdev - Re: [Patch net] xfrm: destroy xfrm_state synchronously on net exit path

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAM_iQpWBkSpEDWS-Vj3_pa3kygB3PiTVQDiBdiLTFY_Ui1oTaw@mail.gmail.com>
Date:   Wed, 30 Jan 2019 08:33:25 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Linux Kernel Network Developers <netdev@...r.kernel.org>
Cc:     syzbot <syzbot+e9aebef558e3ed673934@...kaller.appspotmail.com>,
        Steffen Klassert <steffen.klassert@...unet.com>
Subject: Re: [Patch net] xfrm: destroy xfrm_state synchronously on net exit path

On Tue, Jan 29, 2019 at 10:27 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
> diff --git a/net/ipv6/xfrm6_tunnel.c b/net/ipv6/xfrm6_tunnel.c
> index f5b4febeaa25..08bf374a80eb 100644
> --- a/net/ipv6/xfrm6_tunnel.c
> +++ b/net/ipv6/xfrm6_tunnel.c
> @@ -344,8 +344,7 @@ static void __net_exit xfrm6_tunnel_net_exit(struct net *net)
>         struct xfrm6_tunnel_net *xfrm6_tn = xfrm6_tunnel_pernet(net);
>         unsigned int i;
>
> -       xfrm_state_flush(net, IPSEC_PROTO_ANY, false);
> -       xfrm_flush_gc();
> +       xfrm_state_flush(net, IPSEC_PROTO_ANY, false, true);

Well... We still have to wait for works scheduled from other call path.

I will send v2.