netdev - Re: [PATCH] Revert "ethtool: change to new sane powerpc64 kernel headers"

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190130204117.GC19981@tuxdriver.com>
Date:   Wed, 30 Jan 2019 15:41:17 -0500
From:   "John W. Linville" <linville@...driver.com>
To:     Maciej Żenczykowski <zenczykowski@...il.com>
Cc:     Maciej Żenczykowski <maze@...gle.com>,
        netdev@...r.kernel.org
Subject: Re: [PATCH] Revert "ethtool: change to new sane powerpc64 kernel
 headers"

Cool, thanks -- queued for next release.

John

On Tue, Jan 29, 2019 at 06:48:49PM -0800, Maciej Żenczykowski wrote:
> From: Maciej Żenczykowski <maze@...gle.com>
> 
> This reverts commit 4df55c81996dfb1dbe98c93ee62d8067ed5073a9.
> 
> It turns out this is not needed due to:
>     commit c0a2c04b3cbf6d399a2551654401957ddb529a50
>     internal.h: change to new sane kernel headers on 64-bit archs
> which I apparently entirely forgot about while trying
> to synchronize internal and upstream git repositories.
> 
> Change-Id: I56d90a3c1e9b66c30526824fb7bc41aab01d85d1
> Signed-off-by: Maciej Żenczykowski <maze@...gle.com>
> ---
>  ethtool-copy.h | 6 ------
>  1 file changed, 6 deletions(-)
> 
> diff --git a/ethtool-copy.h b/ethtool-copy.h
> index 7772a4970987..6bfbb85f9402 100644
> --- a/ethtool-copy.h
> +++ b/ethtool-copy.h
> @@ -14,12 +14,6 @@
>  #ifndef _LINUX_ETHTOOL_H
>  #define _LINUX_ETHTOOL_H
>  
> -#ifdef __powerpc64__
> -/* Powerpc needs __SANE_USERSPACE_TYPES__ before <linux/types.h> to select
> - * 'int-ll64.h' and avoid compile warnings when printing __u64 with %llu.
> - */
> -#define __SANE_USERSPACE_TYPES__
> -#endif
>  #include <linux/kernel.h>
>  #include <linux/types.h>
>  #include <linux/if_ether.h>
> -- 
> 2.20.1.495.gaa96b0ce6b-goog
> 
> 

-- 
John W. Linville		Someday the world will need a hero, and you
linville@...driver.com			might be all we have.  Be ready.