netdev - Re: [RFC 03/14] net: hstats: add basic/core functionality

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <a01bc667-dc0a-0844-1bc1-244a166ee540@gmail.com>
Date:   Wed, 30 Jan 2019 15:33:52 -0700
From:   David Ahern <dsahern@...il.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc:     davem@...emloft.net, oss-drivers@...ronome.com,
        netdev@...r.kernel.org, jiri@...nulli.us, f.fainelli@...il.com,
        andrew@...n.ch, mkubecek@...e.cz, simon.horman@...ronome.com,
        jesse.brandeburg@...el.com, maciejromanfijalkowski@...il.com,
        vasundhara-v.volam@...adcom.com, michael.chan@...adcom.com,
        shalomt@...lanox.com, idosch@...lanox.com
Subject: Re: [RFC 03/14] net: hstats: add basic/core functionality

On 1/30/19 10:44 AM, Jakub Kicinski wrote:
> On Tue, 29 Jan 2019 21:18:28 -0700, David Ahern wrote:
>> On 1/28/19 4:44 PM, Jakub Kicinski wrote:
>>> @@ -4946,6 +4964,9 @@ static size_t if_nlmsg_stats_size(const struct net_device *dev,
>>>  		rcu_read_unlock();
>>>  	}
>>>  
>>> +	if (stats_attr_valid(filter_mask, IFLA_STATS_LINK_HSTATS, 0))  
>>
>> filter_mask is populated by RTEXT_FILTER_ from
>> include/uapi/linux/rtnetlink.h
> 
> ext_filter_mask is from IFLA_EXT_MASK and has RTEXT_FILTER_ bits set.
> Here the mask is from struct if_stats_msg::filter_mask of RTM_GETSTATS.
> Am I missing the point? :S

nm. I confused the two filter_mask's.

> 
>>> +		size += rtnl_get_link_hstats_size(dev);  
>>
>> rtnl_get_link_hstats_size == __rtnl_get_link_hstats can return < 0.
> 
> Ups!  Thank you!
> 
> In general how much do you dislike this code? :)
> 

Not having spent much time on the stats details it is hard to follow -
i.e, requires a fair bit of time iterative over the core patches.