netdev - Re: [PATCH net-next v2 6/7] nfp: devlink: report the running and flashed versions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190130142158.433af0ce@cakuba.hsd1.ca.comcast.net>
Date:   Wed, 30 Jan 2019 14:21:58 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Jiri Pirko <jiri@...nulli.us>
Cc:     davem@...emloft.net, netdev@...r.kernel.org,
        oss-drivers@...ronome.com, andrew@...n.ch, f.fainelli@...il.com,
        mkubecek@...e.cz, eugenem@...com, jonathan.lemon@...il.com
Subject: Re: [PATCH net-next v2 6/7] nfp: devlink: report the running and
 flashed versions

On Wed, 30 Jan 2019 22:57:52 +0100, Jiri Pirko wrote:
> >+/* Control processor FW version, FW is responsible for house keeping tasks,
> >+ * PHY control etc.
> >+ */
> >+#define DEVLINK_VERSION_GENERIC_FW_MGMT		"fw.mgmt"
> >+/* Data path microcode controlling high-speed packet processing */
> >+#define DEVLINK_VERSION_GENERIC_FW_APP		"fw.app"
> >+/* UNDI software version */
> >+#define DEVLINK_VERSION_GENERIC_FW_UNDI		"fw.undi"
> >+/* NCSI support/handler version */
> >+#define DEVLINK_VERSION_GENERIC_FW_NCSI		"fw.ncsi"  
> 
> Same here. Also, please put "INFO" in the names to respect the namespacing

Ack on all, and thanks for the reviews!  Do you also think I should add
a doc with them?  I was going back and forth on that..