netdev - Re: ethtool - manual changes in ethtool-copy.h

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CANP3RGdkA4LNNiC3UPcz3b4oGMBPFD2uEyKBMovXJz79eqiO-g@mail.gmail.com>
Date:   Tue, 29 Jan 2019 18:42:04 -0800
From:   Maciej Żenczykowski <maze@...gle.com>
To:     "John W. Linville" <linville@...driver.com>
Cc:     Michal Kubecek <mkubecek@...e.cz>,
        Linux NetDev <netdev@...r.kernel.org>
Subject: Re: ethtool - manual changes in ethtool-copy.h

Eh, I think this patch can simply be reverted.
This is a dupe.  ethtool-copy.h is only included from internal.h which
already includes:

...
#ifndef ETHTOOL_INTERNAL_H__
#define ETHTOOL_INTERNAL_H__

/* Some platforms (eg. ppc64) need __SANE_USERSPACE_TYPES__ before
 * <linux/types.h> to select 'int-ll64.h' and avoid compile warnings
 * when printing __u64 with %llu.
 */
#define __SANE_USERSPACE_TYPES__
...

which came in:

commit c0a2c04b3cbf6d399a2551654401957ddb529a50
Author: Maciej Żenczykowski <maze@...gle.com>
Date:   Fri Mar 11 09:58:14 2016 -0800

    internal.h: change to new sane kernel headers on 64-bit archs

    On ppc64, this fixes:
      ...
    Signed-off-by: Maciej Żenczykowski <maze@...gle.com>
    Signed-off-by: David Decotigny <decot@...glers.com>
    Signed-off-by: Ben Hutchings <ben@...adent.org.uk>

I think I missed this while trying to synchronize internal with upstream repos.
(the local copy of the patch was obviously in the wrong spot)