netdev - Re: [PATCHv4 1/3] net: ethernet: mediatek: support MT7621 SoC ethernet hardware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <48bb34ce-9bb0-2dc1-0e17-55e000a23114@gmail.com>
Date:   Tue, 29 Jan 2019 19:40:39 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     gerg@...nel.org, sean.wang@...iatek.com,
        linux-mediatek@...ts.infradead.org, bjorn@...k.no, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, netdev@...r.kernel.org
Cc:     rene@...rst.com, john@...ozen.org, neil@...wn.name
Subject: Re: [PATCHv4 1/3] net: ethernet: mediatek: support MT7621 SoC
 ethernet hardware



On 1/29/19 5:24 PM, gerg@...nel.org wrote:
> From: Bjørn Mork <bjorn@...k.no>
> 
> The Mediatek MT7621 SoC contains the same ethernet hardware module as
> used on a number of other MediaTek SoC parts. There are some minor
> differences to deal with but we can use the same driver to support
> them all.
> 
> This patch is based on work by Bjørn Mork <bjorn@...k.no>, and his
> original patch is at:
> 
> https://github.com/bmork/LEDE/commit/3293bc63f5461ca1eb0bbc4ed90145335e7e3404
> 
> There is an additional compatible devicetree type added, and the primary
> change to the code required is to support a single interrupt (for both
> RX and TX interrupts).
> 
> Signed-off-by: Bjørn Mork <bjorn@...k.no>
> [gerg@...nel.org: rebase to mainline and irq handler fix]
> Signed-off-by: Greg Ungerer <gerg@...nel.org>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

> ---
>  drivers/net/ethernet/mediatek/Kconfig       |  2 +-
>  drivers/net/ethernet/mediatek/mtk_eth_soc.c | 48 ++++++++++++++++++---
>  drivers/net/ethernet/mediatek/mtk_eth_soc.h |  4 ++
>  3 files changed, 46 insertions(+), 8 deletions(-)
> 
> v2: first in series for this change
> v3: rebase onto 5.0-rc3
> v4: rebase onto 5.0-rc4
> 
> diff --git a/drivers/net/ethernet/mediatek/Kconfig b/drivers/net/ethernet/mediatek/Kconfig
> index f9149d2a4694..43656f961891 100644
> --- a/drivers/net/ethernet/mediatek/Kconfig
> +++ b/drivers/net/ethernet/mediatek/Kconfig
> @@ -1,6 +1,6 @@
>  config NET_VENDOR_MEDIATEK
>  	bool "MediaTek ethernet driver"
> -	depends on ARCH_MEDIATEK
> +	depends on ARCH_MEDIATEK || SOC_MT7621

Would be nice to add COMPILE_TEST there as well at some point so someone
can easily build test changes to the driver.

-- 
Florian