netdev - Re: [PATCH net-next] r8169: improve WoL handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190131.084816.1513814530540032393.davem@davemloft.net>
Date:   Thu, 31 Jan 2019 08:48:16 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     nic_swsd@...ltek.com, netdev@...r.kernel.org
Subject: Re: [PATCH net-next] r8169: improve WoL handling

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Thu, 31 Jan 2019 07:43:30 +0100

> diff --git a/drivers/net/ethernet/realtek/r8169.c b/drivers/net/ethernet/realtek/r8169.c
> index 3e650bd9e..2dab28115 100644
> --- a/drivers/net/ethernet/realtek/r8169.c
> +++ b/drivers/net/ethernet/realtek/r8169.c
> @@ -1371,6 +1371,8 @@ static void rtl_link_chg_patch(struct rtl8169_private *tp)
>  
>  #define WAKE_ANY (WAKE_PHY | WAKE_MAGIC | WAKE_UCAST | WAKE_BCAST | WAKE_MCAST)
>  
> +/* Don't delete it completely, in case we need to re-enable it */
> +#if 0
>  static u32 __rtl8169_get_wol(struct rtl8169_private *tp)

Please don't do this.

The code lives forever in the GIT repository history and can be brought
back in at any time in the future.