netdev - Re: [PATCH net] rds: fix refcount bug in rds_sock

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190131.094619.538460476103388565.davem@davemloft.net>
Date:   Thu, 31 Jan 2019 09:46:19 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        syzkaller@...glegroups.com, sowmini.varadhan@...cle.com,
        santosh.shilimkar@...cle.com, rds-devel@....oracle.com,
        xiyou.wangcong@...il.com
Subject: Re: [PATCH net] rds: fix refcount bug in rds_sock_addref

From: Eric Dumazet <edumazet@...gle.com>
Date: Thu, 31 Jan 2019 08:47:10 -0800

> syzbot was able to catch a bug in rds [1]
> 
> The issue here is that the socket might be found in a hash table
> but that its refcount has already be set to 0 by another cpu.
> 
> We need to use refcount_inc_not_zero() to be safe here.
 ...
> Fixes: cc4dfb7f70a3 ("rds: fix two RCU related problems")
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied and queued up for -stable, thanks Eric.