netdev - Re: [PATCH net] bnxt_en: Disable interrupts when allocating CP rings or NQs.

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Thu, 31 Jan 2019 12:56:19 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     michael.chan@...adcom.com
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] bnxt_en: Disable interrupts when allocating CP
 rings or NQs.

From: Michael Chan <michael.chan@...adcom.com>
Date: Thu, 31 Jan 2019 14:31:48 -0500

> When calling firmware to allocate a CP ring or NQ, an interrupt associated
> with that ring may be generated immediately before the doorbell is even
> setup after the firmware call returns.  When servicing the interrupt, the
> driver may crash when trying to access the doorbell.
> 
> Fix it by disabling interrupt on that vector until the doorbell is
> set up.
> 
> Fixes: 697197e5a173 ("bnxt_en: Re-structure doorbells.")
> Signed-off-by: Michael Chan <michael.chan@...adcom.com>
> ---
> 
> Please queue this for 4.20 stable as well.  Thanks.

Applied and queued up, thanks.