netdev - Re: [PATCH v2 bpf 0/3] bpf: fixes for lockdep and deadlocks

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <75ab4093-902e-6885-4c43-8f5969697528@iogearbox.net>
Date:   Thu, 31 Jan 2019 23:25:53 +0100
From:   Daniel Borkmann <daniel@...earbox.net>
To:     Alexei Starovoitov <ast@...nel.org>, davem@...emloft.net
Cc:     peterz@...radead.org, edumazet@...gle.com, jannh@...gle.com,
        netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH v2 bpf 0/3] bpf: fixes for lockdep and deadlocks

On 01/31/2019 03:12 AM, Alexei Starovoitov wrote:
> v1->v2:
> - reworded 2nd patch. It's a real dead lock. Not a false positive
> - dropped the lockdep fix for up_read_non_owner in bpf_get_stackid
> 
> In addition to preempt_disable patch for socket filters
> https://patchwork.ozlabs.org/patch/1032437/
> First patch fixes lockdep false positive in percpu_freelist
> Second patch fixes potential deadlock in bpf_prog_register
> Third patch fixes another potential deadlock in stackmap access
> from tracing bpf prog and from syscall.
> 
> Alexei Starovoitov (2):
>   bpf: fix lockdep false positive in percpu_freelist
>   bpf: fix potential deadlock in bpf_prog_register
> 
> Martin KaFai Lau (1):
>   bpf: Fix syscall's stackmap lookup potential deadlock
> 
>  kernel/bpf/hashtab.c         |  4 ++--
>  kernel/bpf/percpu_freelist.c | 41 +++++++++++++++++++++++++-----------
>  kernel/bpf/percpu_freelist.h |  4 ++++
>  kernel/bpf/syscall.c         | 12 +++++++++--
>  kernel/trace/bpf_trace.c     | 14 ++----------
>  5 files changed, 47 insertions(+), 28 deletions(-)
> 

Applied, thanks!