netdev - Re: [PATCH] ipconfig: make the wait for carrier timeout configurable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Wed, 30 Jan 2019 21:36:54 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     martink@...teo.de
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org,
        netdev@...r.kernel.org, linux-kernel@...r.kernel.org,
        manfred.schlaegl@...zinger.com, martin.kepplinger@...zinger.com
Subject: Re: [PATCH] ipconfig: make the wait for carrier timeout
 configurable

From: Martin Kepplinger <martink@...teo.de>
Date: Mon, 28 Jan 2019 12:30:05 +0100

> From: Manfred Schlaegl <manfred.schlaegl@...zinger.com>
> 
> commit 3fb72f1e6e61 ("ipconfig wait for carrier") added a
> "wait for carrier" policy, with a fixed worst case maximum wait
> of two minutes.
> 
> This makes the wait for carrier timeout configurable (0 - 240 seconds).
> 
> The informative timeout messages introduced with
> commit 5e404cd65860 ("ipconfig: add informative timeout messages while
> waiting for carrier") were adapted. Message output is done in a fixed
> interval of 20 seconds, just like before (240/12).
> 
> Signed-off-by: Manfred Schlaegl <manfred.schlaegl@...zinger.com>
> Signed-off-by: Martin Kepplinger <martin.kepplinger@...zinger.com>

I would prefer that this be implemented using a kernel command line
parameter.

That way you don't need to rebuild the kernel to adjust the value.

Thanks.