netdev - Re: [PATCH net] l2tp: copy 4 more bytes to linear part if necessary

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190131084304.GA22115@pc-2.home>
Date:   Thu, 31 Jan 2019 09:43:05 +0100
From:   Guillaume Nault <gnault@...hat.com>
To:     Jacob Wen <jian.w.wen@...cle.com>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH net] l2tp: copy 4 more bytes to linear part if necessary

On Thu, Jan 31, 2019 at 03:18:56PM +0800, Jacob Wen wrote:
> The size of L2TPv2 header with all optional fields is 14 bytes.
> l2tp_udp_recv_core only moves 10 bytes to the linear part of a
> skb. This may lead to l2tp_recv_common read data outside of a skb.
> 
Looks good, thanks for taking care of this!

Acked-by: Guillaume Nault <gnault@...hat.com>