netdev - Re: [PATCHv2 net] sctp: check and update stream->out_curr when allocating stream

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190201.103812.1527503455899125278.davem@davemloft.net>
Date:   Fri, 01 Feb 2019 10:38:12 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     nhorman@...driver.com
Cc:     marcelo.leitner@...il.com, lucien.xin@...il.com,
        netdev@...r.kernel.org, linux-sctp@...r.kernel.org
Subject: Re: [PATCHv2 net] sctp: check and update stream->out_curr when
 allocating stream_out

From: Neil Horman <nhorman@...driver.com>
Date: Fri, 1 Feb 2019 07:31:18 -0500

> On Thu, Jan 31, 2019 at 10:39:41PM -0200, Marcelo Ricardo Leitner wrote:
>> On Tue, Jan 29, 2019 at 07:58:07PM +0100, Tuxdriver wrote:
>> > I was initially under the impression that with Kent's repost, the radixtree
>> > (which is what I think you meant by rhashtables) updates would be merged
>> 
>> Oops! Yep.. I had meant flex_arrays actually.
>> 
>> > imminently, but that doesn't seem to be the case.  I'd really like to know
>> > what the hold up there is, as that patch seems to have been stalled for
>> > months.  I hate the notion of breaking the radixtree patch, but if it's
>> > status is indeterminate, then, yes, we probably need to go with xins patch
>> > for the short term, and let Kent fix it up in due course.
>> 
>> Dave, can you please consider applying this patch? The conflict
>> resolution will be easy: just ignore the changes introduced by this
>> patch.
>> 
> Dave I concur with Marcelo here.  Kent was very active in getting sctp fixed up
> to use radixtrees, but now he seems to have gone to ground, and for whatever
> reason, no one seems interested in incorporating his patch.  Its been languising
> for months, so I think we need to take action to secure sctp now until such time
> as his genradix changes finally move forward.

I agree, please let's get this sctp patch resubmitted and back into
patchwork and I will apply it.