netdev - Re: [PATCH v2 net-next 2/5] exthdrs: Registration of TLV handlers and parameters

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Date:   Fri, 01 Feb 2019 14:40:02 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     tom@...bertland.com
Cc:     netdev@...r.kernel.org, tom@...ntonium.net
Subject: Re: [PATCH v2 net-next 2/5] exthdrs: Registration of TLV handlers
 and parameters

From: Tom Herbert <tom@...bertland.com>
Date: Mon, 28 Jan 2019 10:22:52 -0800

> +	tpt = vmalloc(tlv_param_table_size(old->count - 1));
> +	if (!tpt)
> +		return -ENOMEM;
 ...
> +	tsize = tlv_param_table_size(ARRAY_SIZE(tlv_init_params) + 1);
> +
> +	tpt = vmalloc(tsize);
> +	if (!tpt)
> +		return -ENOMEM;

Most of the time this is going to be well within range for a quick, more
efficient, linearly mapped kmalloc allocation.

So please use kvzalloc() or similar for this table.