lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190201.151300.1711434126213839900.davem@davemloft.net> Date: Fri, 01 Feb 2019 15:13:00 -0800 (PST) From: David Miller <davem@...emloft.net> To: gustavo@...eddedor.com Cc: vishal@...lsio.com, netdev@...r.kernel.org, linux-kernel@...r.kernel.org Subject: Re: [PATCH net-next] cxgb4: smt: use struct_size() in kvzalloc() From: "Gustavo A. R. Silva" <gustavo@...eddedor.com> Date: Wed, 30 Jan 2019 18:27:44 -0600 > One of the more common cases of allocation size calculations is > finding the size of a structure that has a zero-sized array at > the end, along with memory for some number of elements for that > array. For example: > > struct foo { > int stuff; > struct boo entry[]; > }; > > instance = kvzalloc(sizeof(struct foo) + count * sizeof(struct boo), GFP_KERNEL); > > Instead of leaving these open-coded and prone to type mistakes, we can now > use the new struct_size() helper: > > instance = kvzalloc(struct_size(instance, entry, count), GFP_KERNEL); > > This code was detected with the help of Coccinelle. > > Signed-off-by: Gustavo A. R. Silva <gustavo@...eddedor.com> Applied.
Powered by blists - more mailing lists