lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC | |
Open Source and information security mailing list archives
| ||
|
Message-Id: <20190201084801.10983-2-hch@lst.de> Date: Fri, 1 Feb 2019 09:47:44 +0100 From: Christoph Hellwig <hch@....de> To: John Crispin <john@...ozen.org>, Vinod Koul <vkoul@...nel.org>, Dmitry Tarnyagin <dmitry.tarnyagin@...kless.no>, Nicolas Ferre <nicolas.ferre@...rochip.com>, Sudip Mukherjee <sudipm.mukherjee@...il.com>, Felipe Balbi <balbi@...nel.org>, linux-mips@...r.kernel.org, linux-kernel@...r.kernel.org, dmaengine@...r.kernel.org, netdev@...r.kernel.org, linux-usb@...r.kernel.org, linux-fbdev@...r.kernel.org, alsa-devel@...a-project.org Cc: iommu@...ts.linux-foundation.org Subject: [PATCH 01/18] MIPS: lantiq: pass struct device to DMA API functions The DMA API generally relies on a struct device to work properly, and only barely works without one for legacy reasons. Pass the easily available struct device from the platform_device to remedy this. Also use GFP_KERNEL instead of GFP_ATOMIC as the gfp_t for the memory allocation, as we aren't in interrupt context or under a lock. Note that this whole function looks somewhat bogus given that we never even look at the returned dma address, and the CPHYSADDR magic on a returned noncached mapping looks "interesting". But I'll leave that to people more familiar with the code to sort out. Signed-off-by: Christoph Hellwig <hch@....de> --- arch/mips/lantiq/xway/vmmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/arch/mips/lantiq/xway/vmmc.c b/arch/mips/lantiq/xway/vmmc.c index 577ec81b557d..3deab9a77718 100644 --- a/arch/mips/lantiq/xway/vmmc.c +++ b/arch/mips/lantiq/xway/vmmc.c @@ -31,8 +31,8 @@ static int vmmc_probe(struct platform_device *pdev) dma_addr_t dma; cp1_base = - (void *) CPHYSADDR(dma_alloc_coherent(NULL, CP1_SIZE, - &dma, GFP_ATOMIC)); + (void *) CPHYSADDR(dma_alloc_coherent(&pdev->dev, CP1_SIZE, + &dma, GFP_KERNEL)); gpio_count = of_gpio_count(pdev->dev.of_node); while (gpio_count > 0) { -- 2.20.1
Powered by blists - more mailing lists