netdev - Re: [PATCH net-next] net: devlink: report cell size of shared buffers

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Date:   Sat, 2 Feb 2019 12:35:51 +0000
From:   Ido Schimmel <idosch@...lanox.com>
To:     Jakub Kicinski <jakub.kicinski@...ronome.com>
CC:     "davem@...emloft.net" <davem@...emloft.net>,
        "jiri@...nulli.us" <jiri@...nulli.us>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        "oss-drivers@...ronome.com" <oss-drivers@...ronome.com>
Subject: Re: [PATCH net-next] net: devlink: report cell size of shared buffers

On Fri, Feb 01, 2019 at 05:56:28PM -0800, Jakub Kicinski wrote:
> Shared buffer allocation is usually done in cell increments.
> Drivers will either round up the allocation or refuse the
> configuration if it's not an exact multiple of cell size.
> Drivers know exactly the cell size of shared buffer, so help
> out users by providing this information in dumps.
> 
> Signed-off-by: Jakub Kicinski <jakub.kicinski@...ronome.com>
> Reviewed-by: Dirk van der Merwe <dirk.vandermerwe@...ronome.com>

Reviewed-by: Ido Schimmel <idosch@...lanox.com>

I assume you're going to patch iproute2. Consider explaining what is
cell size in devlink-sb manpage.

Thanks!