netdev - Re: [PATCH] net: fix IPv6 prefix route residue

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190203.090411.1685970814345088903.davem@redhat.com>
Date:   Sun, 03 Feb 2019 09:04:11 -0800 (PST)
From:   David Miller <davem@...hat.com>
To:     liuzhiqiang26@...wei.com
Cc:     kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, 0xeffeff@...il.com,
        edumazet@...gle.com, netdev@...r.kernel.org,
        mingfangsen@...wei.com, zhangwenhao8@...wei.com,
        wangxiaogang3@...wei.com, zhoukang7@...wei.com
Subject: Re: [PATCH] net: fix IPv6 prefix route residue

From: Zhiqiang Liu <liuzhiqiang26@...wei.com>
Date: Sun, 3 Feb 2019 14:10:31 +0800

> @@ -1165,7 +1165,8 @@ enum cleanup_prefix_rt_t {
>  	list_for_each_entry(ifa, &idev->addr_list, if_list) {
>  		if (ifa == ifp)
>  			continue;
> -		if (!ipv6_prefix_equal(&ifa->addr, &ifp->addr,
> +		if (ifa->prefix_len != ifp->prefix_len ||
> +			!ipv6_prefix_equal(&ifa->addr, &ifp->addr,
>  				       ifp->prefix_len))

Please fix the indentation of this conditional, it should be:

		if (ifa->prefix_len != ifp->prefix_len ||
		    !ipv6_prefix_equal(&ifa->addr, &ifp->addr,
				       ifp->prefix_len))

Thank you.