netdev - Re: [PATCH net-next] net: Fix ip_mc_{dec,inc}

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190203.114005.1068563409105929462.davem@davemloft.net>
Date:   Sun, 03 Feb 2019 11:40:05 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     f.fainelli@...il.com
Cc:     netdev@...r.kernel.org, linus.luessing@...3.blue, andrew@...n.ch,
        roopa@...ulusnetworks.com, nikolay@...ulusnetworks.com,
        kuznet@....inr.ac.ru, yoshfuji@...ux-ipv6.org, sbrivio@...hat.com,
        liuhangbin@...il.com, linux-kernel@...r.kernel.org,
        bridge@...ts.linux-foundation.org
Subject: Re: [PATCH net-next] net: Fix ip_mc_{dec,inc}_group allocation
 context

From: Florian Fainelli <f.fainelli@...il.com>
Date: Fri,  1 Feb 2019 20:20:52 -0800

> After 4effd28c1245 ("bridge: join all-snoopers multicast address"), I
> started seeing the following sleep in atomic warnings:
 ...
> while toggling the bridge's multicast_snooping attribute dynamically.
> 
> Pass a gfp_t down to igmpv3_add_delrec(), introduce
> __igmp_group_dropped() and introduce __ip_mc_dec_group() to take a gfp_t
> argument.
> 
> Similarly introduce ____ip_mc_inc_group() and __ip_mc_inc_group() to
> allow caller to specify gfp_t.
> 
> IPv6 part of the patch appears fine.
> 
> Fixes: 4effd28c1245 ("bridge: join all-snoopers multicast address")
> Signed-off-by: Florian Fainelli <f.fainelli@...il.com>

Applied.

Maybe you could submit a quick test case since you had a reproducer?