lists.openwall.net | lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening PHC | |
Open Source and information security mailing list archives
| ||
|
Date: Sun, 3 Feb 2019 20:56:44 +0100 From: Andrew Lunn <andrew@...n.ch> To: Heiner Kallweit <hkallweit1@...il.com> Cc: Florian Fainelli <f.fainelli@...il.com>, David Miller <davem@...emloft.net>, "netdev@...r.kernel.org" <netdev@...r.kernel.org> Subject: Re: [PATCH 4/4 net-next] net: phy: aquantia: replace magic numbers with constants On Sun, Feb 03, 2019 at 08:35:54PM +0100, Heiner Kallweit wrote: > Replace magic numbers with proper constants. The original patch is > from Andrew, I extended / adjusted certain parts: > - Use decimal bit numbers. The datasheet uses hex bit numbers 0 .. F. > - Order defines from highest to lowest bit numbers > - correct some typos > - add constant MDIO_AN_TX_VEND_INT_MASK2_LINK > - Remove few functional improvements from the patch, they will come as > a separate patch. > > Signed-off-by: Andrew Lunn <andrew@...n.ch> > Signed-off-by: Heiner Kallweit <hkallweit1@...il.com> Reviewed-by: Andrew Lunn <andrew@...n.ch> Andrew
Powered by blists - more mailing lists