netdev - Re: [v2, 0/9] Add ENETC PTP clock driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <20190203.121144.623666032377925349.davem@davemloft.net>
Date:   Sun, 03 Feb 2019 12:11:44 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     yangbo.lu@....com
Cc:     netdev@...r.kernel.org, devicetree@...r.kernel.org,
        richardcochran@...il.com, robh+dt@...nel.org,
        claudiu.manoil@....com
Subject: Re: [v2, 0/9] Add ENETC PTP clock driver

From: David Miller <davem@...emloft.net>
Date: Sun, 03 Feb 2019 11:39:21 -0800 (PST)

> From: Yangbo Lu <yangbo.lu@....com>
> Date: Sat,  2 Feb 2019 10:56:58 +0800
> 
>> There is same QorIQ 1588 timer IP block on the new ENETC Ethernet
>> controller with eTSEC/DPAA Ethernet controllers. However it's
>> different endianness (little-endian) and using PCI driver.
>> 
>> To support ENETC PTP driver, ptp_qoriq driver needed to be
>> reworked to make functions global for reusing, to add little-
>> endian support, to add ENETC memory map support, and to add
>> ENETC dependency for ptp_qoriq driver.
>> 
>> In addition, although ENETC PTP driver is a PCI driver, the dts
>> node still could be used. Currently the ls1028a dtsi which is
>> the only platform by now using ENETC is not complete, so there
>> is still dependency for ENETC PTP node upstreaming. This will
>> be done in the near future. The hardware timestamping support
>> for ENETC is done but needs to be reworked with new method in
>> internal git tree, and will be sent out soon.
> 
> Series applied.

Once AGAIN, I had to revert:

[davem@...alhost net-next]$ make -s -j8
ERROR: "ptp_qoriq_remove_debugfs" [drivers/net/ethernet/freescale/enetc/fsl-enetc-ptp.ko] undefined!
make[1]: *** [scripts/Makefile.modpost:92: __modpost] Error 1
make: *** [Makefile:1262: modules] Error 2

Please do an allmodconfig build and don't resubmit this until it all
passes.

Thank you.