netdev - Re: [PATCH] s390: bpf: fix JMP32 code-gen

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190204174657.txmeyjiezdatwzyw@ast-mbp.dhcp.thefacebook.com>
Date:   Mon, 4 Feb 2019 09:46:58 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Heiko Carstens <heiko.carstens@...ibm.com>
Cc:     Alexei Starovoitov <ast@...nel.org>,
        Martin Schwidefsky <schwidefsky@...ibm.com>,
        Jiong Wang <jiong.wang@...ronome.com>,
        linux-s390@...r.kernel.org, netdev@...r.kernel.org
Subject: Re: [PATCH] s390: bpf: fix JMP32 code-gen

On Mon, Feb 04, 2019 at 04:44:55PM +0100, Heiko Carstens wrote:
> Commit 626a5f66da0d19 ("s390: bpf: implement jitting of JMP32") added
> JMP32 code-gen support for s390. However it triggers the warning below
> due to some unusual gotos in the original s390 bpf jit code.
> 
> Add a couple of additional "is_jmp32" initializations to fix this.
> Also fix the wrong opcode for the "llilf" instruction that was
> introduced with the same commit.
> 
> arch/s390/net/bpf_jit_comp.c: In function 'bpf_jit_insn':
> arch/s390/net/bpf_jit_comp.c:248:55: warning: 'is_jmp32' may be used uninitialized in this function [-Wmaybe-uninitialized]
>   _EMIT6(op1 | reg(b1, b2) << 16 | (rel & 0xffff), op2 | mask); \
>                                                        ^
> arch/s390/net/bpf_jit_comp.c:1211:8: note: 'is_jmp32' was declared here
>    bool is_jmp32 = BPF_CLASS(insn->code) == BPF_JMP32;
> 
> Fixes: 626a5f66da0d19 ("s390: bpf: implement jitting of JMP32")
> Cc: Jiong Wang <jiong.wang@...ronome.com>
> Cc: Martin Schwidefsky <schwidefsky@...ibm.com>
> Signed-off-by: Heiko Carstens <heiko.carstens@...ibm.com>

Applied to bpf-next. Thanks!