[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <20190204071059.GC2249@nanopsycho>
Date: Mon, 4 Feb 2019 08:10:59 +0100
From: Jiri Pirko <jiri@...nulli.us>
To: Jakub Kicinski <jakub.kicinski@...ronome.com>
Cc: dsahern@...il.com, stephen@...workplumber.org,
netdev@...r.kernel.org, oss-drivers@...ronome.com
Subject: Re: [PATCH iproute2-next v2] devlink: add info subcommand
Mon, Feb 04, 2019 at 01:54:56AM CET, jakub.kicinski@...ronome.com wrote:
>Add support for reading the device serial number, driver name
>and various versions. Example:
>
>$ devlink dev info pci/0000:05:00.0
>pci/0000:05:00.0:
> driver nfp
> serial_number 16240145
> versions:
> fixed:
> board.id AMDA0099-0001
> board.rev 07
> board.vendor SMA
> board.model carbon
> running:
> fw.mgmt: 010156.010156.010156
Sometimes you have "x: y" and sometimes you have "x y". Please be
consistent.
Please also include json output here.
Thanks!
> fw.cpld: 0x44
> fw.app: sriov-2.1.16
> stored:
> fw.mgmt: 010158.010158.010158
> fw.cpld: 0x44
> fw.app: sriov-2.1.20
>
>v2 (Jiri):
> - remove filtering;
> - add example in the commit message.
>RFCv2:
> - make info subcommand of dev.
>
[...]
Powered by blists - more mailing lists