netdev - Compiler warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-ID: <ba46f918-243d-c106-6166-28caecdfd81d@ncentric.com>
Date:   Mon, 4 Feb 2019 12:55:33 +0100
From:   Koen Vandeputte <koen.vandeputte@...ntric.com>
To:     netdev@...r.kernel.org
Subject: Compiler warning - ipv4 fib_trie

Hi All,

During compilation of kernel 4.14.96 and 5.0-rc5 I'm seeing following 
warning:

net/ipv4/fib_trie.c: In function 'fib_trie_unmerge':
net/ipv4/fib_trie.c:1749:8: warning: 'local_tp' may be used 
uninitialized in this function [-Wmaybe-uninitialized]
     if (fib_insert_alias(lt, local_tp, local_l, new_fa,
         ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
            NULL, l->key)) {
            ~~~~~~~~~~~~~

Code:

https://elixir.bootlin.com/linux/v5.0-rc5/source/net/ipv4/fib_trie.c#L1731

Looks like 'local_tp' should be NULL-ified


Thanks,

Koen