netdev - Re: linux-next: build warning after merge of the net-next tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190204153254.78c4be0e@canb.auug.org.au>
Date:   Mon, 4 Feb 2019 15:32:54 +1100
From:   Stephen Rothwell <sfr@...b.auug.org.au>
To:     David Miller <davem@...emloft.net>
Cc:     netdev@...r.kernel.org, linux-next@...r.kernel.org,
        linux-kernel@...r.kernel.org, deepa.kernel@...il.com,
        gustavo@...eddedor.com, keescook@...omium.org
Subject: Re: linux-next: build warning after merge of the net-next tree

Hi Dave,

On Sun, 03 Feb 2019 20:26:06 -0800 (PST) David Miller <davem@...emloft.net> wrote:
>
> Thanks, I just pushed the following:
> 
> ====================
> [PATCH] net: Fix fall through warning in y2038 tstamp changes.
> 
> net/core/sock.c: In function 'sock_setsockopt':
> net/core/sock.c:914:3: warning: this statement may fall through [-Wimplicit-fallthrough=]
>    sock_set_flag(sk, SOCK_TSTAMP_NEW);
>    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> net/core/sock.c:915:2: note: here
>   case SO_TIMESTAMPING_OLD:
>   ^~~~
> 
> Fixes: 9718475e6908 ("socket: Add SO_TIMESTAMPING_NEW")
> Reported-by: Stephen Rothwell <sfr@...b.auug.org.au>
> Signed-off-by: David S. Miller <davem@...emloft.net>
> ---
>  net/core/sock.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/net/core/sock.c b/net/core/sock.c
> index a8904ae40713..71ded4d8025c 100644
> --- a/net/core/sock.c
> +++ b/net/core/sock.c
> @@ -912,6 +912,7 @@ int sock_setsockopt(struct socket *sock, int level, int optname,
>  
>  	case SO_TIMESTAMPING_NEW:
>  		sock_set_flag(sk, SOCK_TSTAMP_NEW);
> +		/* fall through */
>  	case SO_TIMESTAMPING_OLD:
>  		if (val & ~SOF_TIMESTAMPING_MASK) {
>  			ret = -EINVAL;

Looks good, thanks.

-- 
Cheers,
Stephen Rothwell

Content of type "application/pgp-signature" skipped