netdev - Re: [PATCH net-next 2/2] net: marvell: mvpp2: fix lack of link interrupts

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190205.104106.1863991682465983305.davem@davemloft.net>
Date:   Tue, 05 Feb 2019 10:41:06 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     rmk+kernel@...linux.org.uk
Cc:     antoine.tenart@...tlin.com, maxime.chevallier@...tlin.com,
        baruch@...s.co.il, netdev@...r.kernel.org
Subject: Re: [PATCH net-next 2/2] net: marvell: mvpp2: fix lack of link
 interrupts

From: Russell King <rmk+kernel@...linux.org.uk>
Date: Mon, 04 Feb 2019 23:35:59 +0000

> Sven Auhagen reports that if he changes a SFP+ module for a SFP module
> on the Macchiatobin Single Shot, the link does not come back up.  For
> Sven, it is as easy as:
> 
> - Insert a SFP+ module connected, and use ping6 to verify link is up.
> - Remove SFP+ module
> - Insert SFP 1000base-X module use ping6 to verify link is up: Link
>   up event did not trigger and the link is down
> 
> but that doesn't show the problem for me.  Locally, this has been
> reproduced by:
> 
> - Boot with no modules.
> - Insert SFP+ module, confirm link is up.
> - Replace module with 25000base-X module.  Confirm link is up.
> - Set remote end down, link is reported as dropped at both ends.
> - Set remote end up, link is reported up at remote end, but not local
>   end due to lack of link interrupt.
> 
> Fix this by setting up both GMAC and XLG interrupts for port 0, but
> only unmasking the appropriate interrupt according to the current mode
> set in the mac_config() method.  However, only do the mask/unmask
> dance when we are really changing the link mode to avoid missing any
> link interrupts.
> 
> Tested-by: Sven Auhagen <sven.auhagen@...eatech.de>
> Signed-off-by: Russell King <rmk+kernel@...linux.org.uk>

Applied.