netdev - Re: [PATCH net] net: defxx: replace dev_kfree_skb_irq by dev_consume_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <alpine.LFD.2.21.1902051816130.9991@eddie.linux-mips.org>
Date:   Tue, 5 Feb 2019 19:57:34 +0000 (GMT)
From:   "Maciej W. Rozycki" <macro@...ux-mips.org>
To:     Yang Wei <albin_yang@....com>
cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        yang.wei9@....com.cn
Subject: Re: [PATCH net] net: defxx: replace dev_kfree_skb_irq by
 dev_consume_skb_irq for drop profiles

On Wed, 6 Feb 2019, Yang Wei wrote:

> From: Yang Wei <yang.wei9@....com.cn>
> 
> dev_consume_skb_irq() should be called in dfx_xmt_done() when skb
> xmit done. It makes drop profiles(dropwatch, perf) more friendly.
> 
> Signed-off-by: Yang Wei <yang.wei9@....com.cn>

Reviewed-by: Maciej W. Rozycki <macro@...ux-mips.org>

 It looks to me the driver has to be reviewed WRT `dev_kfree_skb' vs 
`kfree_skb' use too.  I'll have a look into it unless you are happy to do 
that.

 Thanks for your contribution!

  Maciej