netdev - Re: [PATCH net-next v3 04/16] net: sched: traverse chains in block with tcf_get_next

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190205093530.GA2133@nanopsycho>
Date:   Tue, 5 Feb 2019 10:35:30 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        davem@...emloft.net, ast@...nel.org, daniel@...earbox.net
Subject: Re: [PATCH net-next v3 04/16] net: sched: traverse chains in block
 with tcf_get_next_chain()

Mon, Feb 04, 2019 at 01:32:49PM CET, vladbu@...lanox.com wrote:
>All users of block->chain_list rely on rtnl lock and assume that no new
>chains are added when traversing the list. Use tcf_get_next_chain() to
>traverse chain list without relying on rtnl mutex. This function iterates
>over chains by taking reference to current iterator chain only and doesn't
>assume external synchronization of chain list.
>
>Don't take reference to all chains in block when flushing and use
>tcf_get_next_chain() to safely iterate over chain list instead. Remove
>tcf_block_put_all_chains() that is no longer used.
>
>Signed-off-by: Vlad Buslov <vladbu@...lanox.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>