netdev - Re: [PATCH net-next v3 09/16] net: sched: refactor tp insert/delete for concurrent execution

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190205130812.GF2133@nanopsycho>
Date:   Tue, 5 Feb 2019 14:08:12 +0100
From:   Jiri Pirko <jiri@...nulli.us>
To:     Vlad Buslov <vladbu@...lanox.com>
Cc:     netdev@...r.kernel.org, jhs@...atatu.com, xiyou.wangcong@...il.com,
        davem@...emloft.net, ast@...nel.org, daniel@...earbox.net
Subject: Re: [PATCH net-next v3 09/16] net: sched: refactor tp insert/delete
 for concurrent execution

Mon, Feb 04, 2019 at 01:32:54PM CET, vladbu@...lanox.com wrote:
>Implement unique insertion function to atomically attach tcf_proto to chain
>after verifying that no other tcf proto with specified priority exists.
>Implement delete function that verifies that tp is actually empty before
>deleting it. Use these functions to refactor cls API to account for
>concurrent tp and rule update instead of relying on rtnl lock. Add new
>'deleting' flag to tcf proto. Use it to restart search when iterating over
>tp's on chain to prevent accessing potentially inval tp->next pointer.
>
>Extend tcf proto with spinlock that is intended to be used to protect its
>data from concurrent modification instead of relying on rtnl mutex. Use it
>to protect 'deleting' flag. Add lockdep macros to validate that lock is
>held when accessing protected fields.
>
>Signed-off-by: Vlad Buslov <vladbu@...lanox.com>

Acked-by: Jiri Pirko <jiri@...lanox.com>