netdev - Re: [PATCH bpf-next] tools: bpftool: doc, add text about feature-subcommand

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <f0c5096c-2b76-e85f-7625-37ddbb5bba41@netronome.com>
Date:   Wed, 6 Feb 2019 09:42:26 +0000
From:   Quentin Monnet <quentin.monnet@...ronome.com>
To:     Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>,
        Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>
Cc:     netdev@...r.kernel.org
Subject: Re: [PATCH bpf-next] tools: bpftool: doc, add text about
 feature-subcommand

2019-02-06 10:45 UTC+0900 ~ Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>
> This patch adds missing information about feature-subcommand in
> bpftool.rst
> 
> Signed-off-by: Prashant Bhole <bhole_prashant_q7@....ntt.co.jp>

My bad, thanks a lot for the update!

> ---
>   tools/bpf/bpftool/Documentation/bpftool.rst | 4 +++-
>   1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/bpf/bpftool/Documentation/bpftool.rst b/tools/bpf/bpftool/Documentation/bpftool.rst
> index 27153bb816ac..0685d5ada3ce 100644
> --- a/tools/bpf/bpftool/Documentation/bpftool.rst
> +++ b/tools/bpf/bpftool/Documentation/bpftool.rst
> @@ -16,7 +16,7 @@ SYNOPSIS
>   
>   	**bpftool** **version**
>   
> -	*OBJECT* := { **map** | **program** | **cgroup** | **perf** | **net** }
> +	*OBJECT* := { **map** | **program** | **cgroup** | **perf** | **net** | **feature** }
>   
>   	*OPTIONS* := { { **-V** | **--version** } | { **-h** | **--help** }
>   	| { **-j** | **--json** } [{ **-p** | **--pretty** }] }
> @@ -34,6 +34,8 @@ SYNOPSIS
>   
>   	*NET-COMMANDS* := { **show** | **list** | **help** }
>   
> +        *FEATURE-COMMANDS* := { **probe** | **help** }

Could you please fix this line to use a tab instead of spaces for 
indent, as for the rest of the file?

> +
>   DESCRIPTION
>   ===========
>   	*bpftool* allows for inspection and simple modification of BPF objects
>