netdev - Re: [PATCH net] mISDN: fix a race in dev_expire

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190205.163957.1465468872543244862.davem@davemloft.net>
Date:   Tue, 05 Feb 2019 16:39:57 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     edumazet@...gle.com
Cc:     netdev@...r.kernel.org, eric.dumazet@...il.com,
        isdn@...ux-pingi.de, syzkaller@...glegroups.com
Subject: Re: [PATCH net] mISDN: fix a race in dev_expire_timer()

From: Eric Dumazet <edumazet@...gle.com>
Date: Tue,  5 Feb 2019 15:38:44 -0800

> Since mISDN_close() uses dev->pending to iterate over active
> timers, there is a chance that one timer got removed from the
> ->pending list in dev_expire_timer() but that the thread
> has not called yet wake_up_interruptible()
> 
> So mISDN_close() could miss this and free dev before
> completion of at least one dev_expire_timer()
> 
> syzbot was able to catch this race :
 ...
> Signed-off-by: Eric Dumazet <edumazet@...gle.com>
> Cc: Karsten Keil <isdn@...ux-pingi.de>
> Reported-by: syzbot <syzkaller@...glegroups.com>

Applied.