[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <20190206172316.olapzjsv7e3jr3nv@shell.armlinux.org.uk>
Date: Wed, 6 Feb 2019 17:23:17 +0000
From: Russell King - ARM Linux admin <linux@...linux.org.uk>
To: Maxime Chevallier <maxime.chevallier@...tlin.com>
Cc: Andrew Lunn <andrew@...n.ch>,
Gregory Clement <gregory.clement@...tlin.com>,
Jason Cooper <jason@...edaemon.net>,
Kishon Vijay Abraham I <kishon@...com>,
Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>,
Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
devicetree@...r.kernel.org, linux-arm-kernel@...ts.infradead.org,
netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>
Subject: Re: [PATCH net-next 5/6] net: marvell: neta: add comphy support
On Wed, Feb 06, 2019 at 04:09:28PM +0100, Maxime Chevallier wrote:
> Hello Russell,
>
> On Wed, 06 Feb 2019 11:35:07 +0000
> Russell King <rmk+kernel@...linux.org.uk> wrote:
>
>
> >+ if (pp->comphy) {
> >+ enum phy_mode mode = PHY_MODE_INVALID;
> >+
> >+ switch (state->interface) {
> >+ case PHY_INTERFACE_MODE_SGMII:
> >+ case PHY_INTERFACE_MODE_1000BASEX:
> >+ mode = PHY_MODE_SGMII;
>
> PHY_MODE_SGMII no longer exists, the new PHY_MODE_ETHERNET must be used
> with the correct submode now, so this doesn't build unfortunately.
>
> >+ break;
> >+ case PHY_INTERFACE_MODE_2500BASEX:
> >+ mode = PHY_MODE_2500SGMII;
>
> Same here.
Of course, I knew there was some reason I hadn't sent them yet... thanks
for spotting.
--
RMK's Patch system: https://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line in suburbia: sync at 12.1Mbps down 622kbps up
According to speedtest.net: 11.9Mbps down 500kbps up
Powered by blists - more mailing lists