netdev - Re: [PATCH net] net: dsa: Fix NULL checking in dsa_slave_set

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <325618d9-934e-dcd5-0032-26823c971c4a@gmail.com>
Date:   Wed, 6 Feb 2019 09:42:46 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     Dan Carpenter <dan.carpenter@...cle.com>,
        Andrew Lunn <andrew@...n.ch>
Cc:     Vivien Didelot <vivien.didelot@...il.com>,
        "David S. Miller" <davem@...emloft.net>, netdev@...r.kernel.org,
        kernel-janitors@...r.kernel.org
Subject: Re: [PATCH net] net: dsa: Fix NULL checking in dsa_slave_set_eee()

On 2/6/19 7:35 AM, Dan Carpenter wrote:
> This function can't succeed if dp->pl is NULL.  It will Oops inside the
> call to return phylink_ethtool_get_eee(dp->pl, e);
> 
> Fixes: 1be52e97ed3e ("dsa: slave: eee: Allow ports to use phylink")
> Signed-off-by: Dan Carpenter <dan.carpenter@...cle.com>

Reviewed-by: Florian Fainelli <f.fainelli@...il.com>

thanks Dan!
-- 
Florian