netdev - Re: [PATCH 00/12 net-next,v7] add flow

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <1376e1e0-40d6-8b2e-0b36-dd259cece2d8@gmail.com>
Date:   Wed, 6 Feb 2019 12:44:53 -0800
From:   Florian Fainelli <f.fainelli@...il.com>
To:     David Miller <davem@...emloft.net>, pablo@...filter.org
Cc:     netdev@...r.kernel.org, thomas.lendacky@....com,
        ariel.elior@...ium.com, michael.chan@...adcom.com,
        santosh@...lsio.com, madalin.bucur@....com,
        yisen.zhuang@...wei.com, salil.mehta@...wei.com,
        jeffrey.t.kirsher@...el.com, tariqt@...lanox.com,
        saeedm@...lanox.com, jiri@...lanox.com, idosch@...lanox.com,
        jakub.kicinski@...ronome.com, peppe.cavallaro@...com,
        grygorii.strashko@...com, andrew@...n.ch,
        vivien.didelot@...oirfairelinux.com, alexandre.torgue@...com,
        joabreu@...opsys.com, linux-net-drivers@...arflare.com,
        ganeshgr@...lsio.com, ogerlitz@...lanox.com,
        Manish.Chopra@...ium.com, marcelo.leitner@...il.com,
        mkubecek@...e.cz, venkatkumar.duvvuru@...adcom.com,
        julia.lawall@...6.fr, john.fastabend@...il.com,
        netfilter-devel@...r.kernel.org, cphealy@...il.com
Subject: Re: [PATCH 00/12 net-next,v7] add flow_rule infrastructure

On 2/6/19 10:39 AM, David Miller wrote:
> From: Pablo Neira Ayuso <pablo@...filter.org>
> Date: Sat,  2 Feb 2019 12:50:42 +0100
> 
>> This patchset, as is, allows us to reuse the driver codebase to
>> configure ACL hardware offloads for the ethtool_rxnfc and the TC flower
>> interfaces. A few clients for this infrastructure are presented, such as
>> the bcm_sf2 and the qede drivers, for reference. Moreover all of the
>> existing drivers in the tree are converted to use this infrastructure.
>>
>> This patchset is re-using the existing flow dissector infrastructure
>> that was introduced by Jiri Pirko et al. so the amount of abstractions
>> that this patchset adds are minimal. Well, just a few wrapper structures
>> for the selector side of the rules. And, in order to express actions,
>> this patchset exposes an action API that is based on the existing TC
>> action infrastructure and what existing drivers already support on that
>> front.
>>
>> v7: This patchset is a rebase on top of the net-next tree, after
>>     addressing questions and feedback from driver developers in the
>>     last batch.
> 
> Ok, I've thought long and hard about this.
> 
> Applied to net-next, let's see where this goes.
> 
> I'll push this out after my build testing completes.

Great! Thanks. FWIW, I just ran basic testing on bcm_sf2 with this
series applied and have not had regressions, so this is good.
-- 
Florian