netdev - Re: [PATCH net-next] net: phy: fixed_phy: Fix fixed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190206215905.GD32483@lunn.ch>
Date:   Wed, 6 Feb 2019 22:59:05 +0100
From:   Andrew Lunn <andrew@...n.ch>
To:     Moritz Fischer <mdf@...nel.org>
Cc:     netdev@...r.kernel.org, f.fainelli@...il.com, hkallweit1@...il.com,
        davem@...emloft.net
Subject: Re: [PATCH net-next] net: phy: fixed_phy: Fix fixed_phy not checking
 GPIO

On Wed, Feb 06, 2019 at 10:10:40AM -0800, Moritz Fischer wrote:
> Fix fixed_phy not checking GPIO if no link_update callback
> is registered.
> 
> Signed-off-by: Moritz Fischer <mdf@...nel.org>
> ---
> 
> Hi all,
> 
> I've been trying to figure out where exactly this broke,
> it must've been somewhere when the file was refactored
> in connection with phylink?

Hi Moritz

With a quick inspection, i also cannot see where it broken.

I think part of the issue is that all the current users have moved
onto using phylink, and phylink polls the GPIO, rather than having
fixed_link do it.

I would prefer to understand exactly which change broke it. Without
knowing how it broke, it is hard to say if this is the correct fix.

What is your use-case? You Cc: the usb list. So a USB-Ethernet dongle?
But then why fixed-link?

	Andrew