netdev - Re: [ISSUE][4.20.6] mlx5 and checksum failures

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAM_iQpWMdMG_wtvHa9NQHQnQ4AuEEH2FcsJ2nWptSqFD_-6-Ww@mail.gmail.com>
Date:   Wed, 6 Feb 2019 14:49:08 -0800
From:   Cong Wang <xiyou.wangcong@...il.com>
To:     Ian Kumlien <ian.kumlien@...il.com>
Cc:     David Miller <davem@...emloft.net>,
        Saeed Mahameed <saeedm@...lanox.com>,
        Linux Kernel Network Developers <netdev@...r.kernel.org>
Subject: Re: [ISSUE][4.20.6] mlx5 and checksum failures

On Wed, Feb 6, 2019 at 2:41 PM Ian Kumlien <ian.kumlien@...il.com> wrote:
>
> On Wed, Feb 6, 2019 at 11:38 PM Cong Wang <xiyou.wangcong@...il.com> wrote:
> > On Wed, Feb 6, 2019 at 2:15 PM Ian Kumlien <ian.kumlien@...il.com> wrote:
> > > Could we please schedule this for 4.19 and 4.20 - it's kinda breaking things
> >
> > It doesn't break anything, packets are _not_ dropped, only that the
> > warning itself is noisy.
>
> Not my experience, to me it slows the machine down and looses packets,
> I don't however know
> if this is the only culprit

The packet process could be slow down because of printing
out this kernel warning. Packet should be still delivered to upper
stack, at least I didn't see any packet drops because of this.

>
> You can actually see it on ping where it start out with 0.0xyx and
> ends up at ~10ms
>

I don't understand how it could affect ICMP, it is purely TCP
from my point of view, even the stack trace from you says so. ;)

Thanks.