netdev - Re: [PATCH bpf-next 1/2] tools/bpf: add const qualifier to btf__get_map_kv_tids() map

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAADnVQ+YWx5e7+T_ht8WQfvRWu8mrzc3b8J4zfS+NWXCrFvbsg@mail.gmail.com>
Date:   Tue, 5 Feb 2019 18:41:01 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     Network Development <netdev@...r.kernel.org>,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>,
        Kernel Team <kernel-team@...com>
Subject: Re: [PATCH bpf-next 1/2] tools/bpf: add const qualifier to
 btf__get_map_kv_tids() map_name parameter

On Tue, Feb 5, 2019 at 6:27 PM Alexei Starovoitov
<alexei.starovoitov@...il.com> wrote:
>
> On Tue, Feb 05, 2019 at 11:48:22AM -0800, Yonghong Song wrote:
> > Commit 96408c43447a ("tools/bpf: implement libbpf btf__get_map_kv_tids() API function")
> > added the API function btf__get_map_kv_tids():
> >   btf__get_map_kv_tids(const struct btf *btf, char *map_name, ...)
> >
> > The parameter map_name has type "char *". This is okay inside libbpf library since
> > the map_name is from bpf_map->name which also has type "char *".
> >
> > This will be problematic if the caller for map_name already has attribute "const",
> > e.g., from C++ string.c_str(). It will result in either a warning or an error.
> >
> >   /home/yhs/work/bcc/src/cc/btf.cc:166:51:
> >     error: invalid conversion from ‘const char*’ to ‘char*’ [-fpermissive]
> >       return btf__get_map_kv_tids(btf_, map_name.c_str()
> >
> > This patch added "const" attributes to map_name parameter.
> >
> > Fixes: 96408c43447a ("tools/bpf: implement libbpf btf__get_map_kv_tids() API function")
> > Signed-off-by: Yonghong Song <yhs@...com>
>
> Acked-by: Alexei Starovoitov <ast@...nel.org>

Actually just applied this patch alone,
since it's independent from 2nd.