netdev - Re: [PATCH bpf-next] tools/bpf: silence a libbpf unnecessary warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190206060917.rdiq5s5puy672ral@ast-mbp.dhcp.thefacebook.com>
Date:   Tue, 5 Feb 2019 22:09:18 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Yonghong Song <yhs@...com>
Cc:     Andrii Nakryiko <andriin@...com>, netdev@...r.kernel.org,
        Alexei Starovoitov <ast@...com>,
        Daniel Borkmann <daniel@...earbox.net>, kernel-team@...com
Subject: Re: [PATCH bpf-next] tools/bpf: silence a libbpf unnecessary warning

On Tue, Feb 05, 2019 at 09:38:30PM -0800, Yonghong Song wrote:
> Commit 96408c43447a ("tools/bpf: implement libbpf
> btf__get_map_kv_tids() API function") refactored
> function bpf_map_find_btf_info() and moved bulk of
> implementation into btf.c as btf__get_map_kv_tids().
> This change introduced a bug such that test_btf will
> print out the following warning although the test passed:
>   BTF libbpf test[2] (test_btf_nokv.o): libbpf: map:btf_map
>       container_name:____btf_map_btf_map cannot be found
>       in BTF. Missing BPF_ANNOTATE_KV_PAIR?
> 
> Previously, the error message is guarded with pr_debug().
> Commit 96408c43447a changed it to pr_warning() and
> hence caused the warning.
> 
> Restoring to pr_debug() for the message fixed the issue.
> 
> Fixes: 96408c43447a ("tools/bpf: implement libbpf btf__get_map_kv_tids() API function")
> Signed-off-by: Yonghong Song <yhs@...com>

Applied. It fixed the issue I was seeing. Thanks!