lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Date:   Wed, 6 Feb 2019 16:51:21 -0800
From:   Saeed Mahameed <>
To:     Eric Dumazet <>
Cc:     Cong Wang <>,
        Linux Kernel Network Developers <>,
        Saeed Mahameed <>,
        Tariq Toukan <>
Subject: Re: [Patch net-next v2] mlx5: use RCU lock in mlx5_eq_cq_get()

On Wed, Feb 6, 2019 at 4:28 PM Eric Dumazet <> wrote:
> On 02/06/2019 04:04 PM, Cong Wang wrote:
> > synchronize_irq() is called before mlx5_cq_put(), so I don't
> > see why readers could get 0 refcnt.
> Then the more reasons to get rid of the refcount increment/decrement completely ...
> Technically, even the rcu_read_lock() and rcu_read_unlock() are not needed,
> since synchronize_irq() is enough.

I already suggested this, quoting myself from my first reply to this patch V0:
"another way to do it is not to do any refcounting in the irq handler
and fence cq removal via synchronize_irq(eq->irqn) on mlx5_eq_del_cq."

I already have a patch I was just waiting for Cong to push V2.

Powered by blists - more mailing lists