netdev - Re: [PATCH net] vsock: cope with memory allocation failure at socket creation time

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190207133733.bskvbvekrdm2244v@steredhat>
Date:   Thu, 7 Feb 2019 14:37:33 +0100
From:   Stefano Garzarella <sgarzare@...hat.com>
To:     Paolo Abeni <pabeni@...hat.com>
Cc:     netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
        Jorgen Hansen <jhansen@...are.com>
Subject: Re: [PATCH net] vsock: cope with memory allocation failure at socket
 creation time

On Thu, Feb 07, 2019 at 02:13:18PM +0100, Paolo Abeni wrote:
> In the unlikely event that the kmalloc call in vmci_transport_socket_init()
> fails, we end-up calling vmci_transport_destruct() with a NULL vmci_trans()
> and oopsing.
> 
> This change addresses the above explicitly checking for zero vmci_trans()
> at destruction time.
> 
> Reported-by: Xiumei Mu <xmu@...hat.com>
> Fixes: d021c344051a ("VSOCK: Introduce VM Sockets")
> Signed-off-by: Paolo Abeni <pabeni@...hat.com>
> ---
>  net/vmw_vsock/vmci_transport.c | 4 ++++
>  1 file changed, 4 insertions(+)

Reviewed-by: Stefano Garzarella <sgarzare@...hat.com>

Thanks,
Stefano