netdev - Re: [PATCH bpf-next v7 2/6] bpf: implement BPF_LWT_ENCAP_IP mode in bpf_lwt_push

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <201902072257.ii9I5dX0%fengguang.wu@intel.com>
Date:   Thu, 7 Feb 2019 22:04:06 +0800
From:   kbuild test robot <lkp@...el.com>
To:     Peter Oskolkov <posk@...gle.com>
Cc:     kbuild-all@...org, Alexei Starovoitov <ast@...nel.org>,
        Daniel Borkmann <daniel@...earbox.net>, netdev@...r.kernel.org,
        Peter Oskolkov <posk@...k.io>, David Ahern <dsahern@...il.com>,
        Willem de Bruijn <willemb@...gle.com>,
        Peter Oskolkov <posk@...gle.com>
Subject: Re: [PATCH bpf-next v7 2/6] bpf: implement BPF_LWT_ENCAP_IP mode in
 bpf_lwt_push_encap

Hi Peter,

Thank you for the patch! Yet something to improve:

[auto build test ERROR on bpf-next/master]

url:    https://github.com/0day-ci/linux/commits/Peter-Oskolkov/bpf-add-BPF_LWT_ENCAP_IP-option-to-bpf_lwt_push_encap/20190207-205725
base:   https://git.kernel.org/pub/scm/linux/kernel/git/bpf/bpf-next.git master
config: i386-defconfig (attached as .config)
compiler: gcc-8 (Debian 8.2.0-14) 8.2.0
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All errors (new ones prefixed by >>):

   net//core/filter.c: In function 'bpf_push_ip_encap':
>> net//core/filter.c:4808:9: error: implicit declaration of function 'bpf_lwt_push_ip_encap'; did you mean 'bpf_push_ip_encap'? [-Werror=implicit-function-declaration]
     return bpf_lwt_push_ip_encap(skb, hdr, len, ingress);
            ^~~~~~~~~~~~~~~~~~~~~
            bpf_push_ip_encap
   At top level:
   net//core/filter.c:4805:12: warning: 'bpf_push_ip_encap' defined but not used [-Wunused-function]
    static int bpf_push_ip_encap(struct sk_buff *skb, void *hdr, u32 len,
               ^~~~~~~~~~~~~~~~~
   cc1: some warnings being treated as errors

vim +4808 net//core/filter.c

  4804	
  4805	static int bpf_push_ip_encap(struct sk_buff *skb, void *hdr, u32 len,
  4806				     bool ingress)
  4807	{
> 4808		return bpf_lwt_push_ip_encap(skb, hdr, len, ingress);
  4809	}
  4810	

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Download attachment ".config.gz" of type "application/gzip" (26942 bytes)