netdev - [PATCH] ipv6: fix icmp6

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Date:   Thu,  7 Feb 2019 16:05:31 +0100
From:   Alin Nastac <alin.nastac@...il.com>
To:     netdev@...r.kernel.org
Subject: [PATCH] ipv6: fix icmp6_send() route lookup

Original packet destination address must be used as saddr for the
route lookup performed by icmp6_send() even when this address is
not local. This fixes the IPv6 router ability to send back
destination unreachable ICMPv6 errors for forwarded packets when
the route toward the saddr of the original packet is source
filtered (e.g. a default route with a "from PD" attribute, where
PD is the delegated prefix).

Signed-off-by: Alin Nastac <alin.nastac@...il.com>
---
 net/ipv6/icmp.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/net/ipv6/icmp.c b/net/ipv6/icmp.c
index bbcdfd2..8f17065 100644
--- a/net/ipv6/icmp.c
+++ b/net/ipv6/icmp.c
@@ -455,8 +455,7 @@ static void icmp6_send(struct sk_buff *skb, u8 type, u8 code, __u32 info,
 	 */
 	addr_type = ipv6_addr_type(&hdr->daddr);

-	if (ipv6_chk_addr(net, &hdr->daddr, skb->dev, 0) ||
-	    ipv6_chk_acast_addr_src(net, skb->dev, &hdr->daddr))
+	if (!force_saddr)
 		saddr = &hdr->daddr;

 	/*
-- 
2.7.4