netdev - Re: [PATCH net] net: sun: replace dev_kfree_skb_irq by dev_consume_skb

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <951b48c4-2c9b-a2cf-b00f-d29c9f7a0f3e@oracle.com>
Date:   Thu, 7 Feb 2019 09:51:12 +0800
From:   Yanjun Zhu <yanjun.zhu@...cle.com>
To:     Yang Wei <albin_yang@....com>, netdev@...r.kernel.org
Cc:     davem@...emloft.net, shannon.nelson@...cle.com, robh@...nel.org,
        yang.wei9@....com.cn
Subject: Re: [PATCH net] net: sun: replace dev_kfree_skb_irq by
 dev_consume_skb_irq for drop profiles


On 2019/2/6 0:19, Yang Wei wrote:
> From: Yang Wei <yang.wei9@....com.cn>
>
> dev_consume_skb_irq() should be called when skb xmit done. It makes
> drop profiles(dropwatch, perf) more friendly.

Thanks a lot. I am OK.

Zhu Yanjun

>
> Signed-off-by: Yang Wei <yang.wei9@....com.cn>
> ---
>   drivers/net/ethernet/sun/cassini.c | 2 +-
>   drivers/net/ethernet/sun/sunbmac.c | 2 +-
>   drivers/net/ethernet/sun/sunhme.c  | 2 +-
>   3 files changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/net/ethernet/sun/cassini.c b/drivers/net/ethernet/sun/cassini.c
> index 7ec4eb7..6fc05c1 100644
> --- a/drivers/net/ethernet/sun/cassini.c
> +++ b/drivers/net/ethernet/sun/cassini.c
> @@ -1898,7 +1898,7 @@ static inline void cas_tx_ringN(struct cas *cp, int ring, int limit)
>   		cp->net_stats[ring].tx_packets++;
>   		cp->net_stats[ring].tx_bytes += skb->len;
>   		spin_unlock(&cp->stat_lock[ring]);
> -		dev_kfree_skb_irq(skb);
> +		dev_consume_skb_irq(skb);
>   	}
>   	cp->tx_old[ring] = entry;
>   
> diff --git a/drivers/net/ethernet/sun/sunbmac.c b/drivers/net/ethernet/sun/sunbmac.c
> index 720b7ac..e9b757b 100644
> --- a/drivers/net/ethernet/sun/sunbmac.c
> +++ b/drivers/net/ethernet/sun/sunbmac.c
> @@ -781,7 +781,7 @@ static void bigmac_tx(struct bigmac *bp)
>   
>   		DTX(("skb(%p) ", skb));
>   		bp->tx_skbs[elem] = NULL;
> -		dev_kfree_skb_irq(skb);
> +		dev_consume_skb_irq(skb);
>   
>   		elem = NEXT_TX(elem);
>   	}
> diff --git a/drivers/net/ethernet/sun/sunhme.c b/drivers/net/ethernet/sun/sunhme.c
> index ff641cf..d007dfe 100644
> --- a/drivers/net/ethernet/sun/sunhme.c
> +++ b/drivers/net/ethernet/sun/sunhme.c
> @@ -1962,7 +1962,7 @@ static void happy_meal_tx(struct happy_meal *hp)
>   			this = &txbase[elem];
>   		}
>   
> -		dev_kfree_skb_irq(skb);
> +		dev_consume_skb_irq(skb);
>   		dev->stats.tx_packets++;
>   	}
>   	hp->tx_old = elem;