netdev - Re: [EXT] Re: [PATCH net-next 0/2] qed*: SmartAN query support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190208080429.0411ea05@cakuba.netronome.com>
Date:   Fri, 8 Feb 2019 08:04:29 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Sudarsana Reddy Kalluru <skalluru@...vell.com>
Cc:     "davem@...emloft.net" <davem@...emloft.net>,
        "netdev@...r.kernel.org" <netdev@...r.kernel.org>,
        Ariel Elior <aelior@...vell.com>,
        Michal Kalderon <mkalderon@...vell.com>,
        Michal Kubecek <mkubecek@...e.cz>
Subject: Re: [EXT] Re: [PATCH net-next 0/2] qed*: SmartAN query support

On Fri, 8 Feb 2019 11:32:14 +0000, Sudarsana Reddy Kalluru wrote:
> >On Thu, 7 Feb 2019 06:20:10 -0800, Sudarsana Reddy Kalluru wrote:  
> >> SmartAN feature detects the peer/cable capabilities and establishes
> >> the link in the best possible configuration.  
> >
> >It sounds familiar, I need to check with FW team, but I think we may be doing
> >a similar thing, and adding a common API rather than ethtool flag would be
> >preferable.
> >
> >Could you please share a little bit more detail?  What are the configurations
> >this would choose between?  
> 
> Jakub,
>   Following doc provides detailed information on this feature. We simply need a flag to display whether the feature is enabled in the hardware or not, hence adding it to "ethtool --show-priv-flags".
> https://www.cavium.com/Dell/Documents/Converged/TB_Establishing_Adaptive_Links_with_SmartAN_Dell.pdf

Thanks!  Yes, that's exactly the same thing.  In a nutshell trying
different serdes and FEC speeds.  I guess I'll just put adding an API
for this down as a TODO, and add it once we have ethtool netlink.  And
keep IOCTL ethtool frozen until then.

So I think the priv flag is fine for now.