netdev - Re: [PATCH net-next] nfp: flower: remove unused index from nfp_fl

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20190208084731.52434d84@cakuba.netronome.com>
Date:   Fri, 8 Feb 2019 08:47:31 -0800
From:   Jakub Kicinski <jakub.kicinski@...ronome.com>
To:     Pablo Neira Ayuso <pablo@...filter.org>
Cc:     netdev@...r.kernel.org, davem@...emloft.net,
        oss-drivers@...ronome.com
Subject: Re: [PATCH net-next] nfp: flower: remove unused index from
 nfp_fl_pedit()

On Fri,  8 Feb 2019 17:41:13 +0100, Pablo Neira Ayuso wrote:
> Static checker warning complains on uninitialized variable:
> 
>         drivers/net/ethernet/netronome/nfp/flower/action.c:618 nfp_fl_pedit()
>         error: uninitialized symbol 'idx'.
> 
> Which is actually never used from the functions that take it as
> parameter. Remove it.
> 
> Fixes: 738678817573 ("drivers: net: use flow action infrastructure")

Hardly a fix.  It's completely unused.

> Reported-by: Dan Carpenter <dan.carpenter@...cle.com>
> Signed-off-by: Pablo Neira Ayuso <pablo@...filter.org>

Ah, I was hoping you wouldn't notice :)  Now the backport of this code
got almost as excruciatingly painful as the match part :)  But I guess
nothing we can do about it:

Acked-by: Jakub Kicinski <jakub.kicinski@...ronome.com>