netdev - Re: [PATCH v2 net-next] net: phy: let genphy_c45_read

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20190207.181720.264383318203577068.davem@davemloft.net>
Date:   Thu, 07 Feb 2019 18:17:20 -0800 (PST)
From:   David Miller <davem@...emloft.net>
To:     hkallweit1@...il.com
Cc:     andrew@...n.ch, f.fainelli@...il.com, linux@...linux.org.uk,
        netdev@...r.kernel.org
Subject: Re: [PATCH v2 net-next] net: phy: let genphy_c45_read_link manage
 the devices to check

From: Heiner Kallweit <hkallweit1@...il.com>
Date: Thu, 7 Feb 2019 21:41:46 +0100

> Let genphy_c45_read_link manage the devices to check, this removes
> overhead from callers. Add C22EXT to the list of excluded devices
> because it doesn't implement the status register. According to the
> 802.3 clause 45 spec registers 29.0 - 29.4 are reserved.
> 
> At the moment we have very few clause 45 PHY drivers, so we are
> lacking experience whether other drivers will have to exclude further
> devices, or may need to check PHY XS. If we should figure out that
> list of devices to check needs to be configurable, I think best will
> be to add a device list member to struct phy_driver.
> 
> v2:
> - adjusted commit message
> - exclude also device C22EXT from link checking
> 
> Signed-off-by: Heiner Kallweit <hkallweit1@...il.com>

Applied.