netdev - Re: [PATCH v2 bpf-next] tools/bpf: add missing strings.h include

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20190208022120.zcpgxmw2pn7zhgcl@ast-mbp.dhcp.thefacebook.com>
Date:   Thu, 7 Feb 2019 18:21:21 -0800
From:   Alexei Starovoitov <alexei.starovoitov@...il.com>
To:     Andrii Nakryiko <andriin@...com>
Cc:     acme@...nel.org, andrii.nakryiko@...il.com, yhs@...com,
        songliubraving@...com, ast@...com, kafai@...com,
        netdev@...r.kernel.org, kernel-team@...com
Subject: Re: [PATCH v2 bpf-next] tools/bpf: add missing strings.h include

On Thu, Feb 07, 2019 at 11:29:24AM -0800, Andrii Nakryiko wrote:
> Few files in libbpf are using bzero() function (defined in strings.h header), but
> don't include corresponding header. When libbpf is added as a dependency to pahole,
> this undeterministically causes warnings on some machines:
> 
> bpf.c:225:2: warning: implicit declaration of function ‘bzero’ [-Wimplicit-function-declaration]
>   bzero(&attr, sizeof(attr));
>     ^~~~~
> 
> Signed-off-by: Andrii Nakryiko <andriin@...com>
> Reported-by: Arnaldo Carvalho de Melo <acme@...hat.com>

Applied, Thanks